Standardize serialization of CalibrationTag #7480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Jul 11, 2025
- Serialize CalibrationTag as a tag rather than use a custom token index field.
- This tag was not converted over to the new Tag message since I didn't think anyone was still using it.
- Serialize CalibrationTag as a tag rather than use a custom token index field. - This tag was not converted over to the new Tag message since I didn't think anyone was still using it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7480 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 1092 1092
Lines 96816 96827 +11
==========================================
+ Hits 95546 95554 +8
- Misses 1270 1273 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
approved these changes
Jul 11, 2025
ddddddanni
pushed a commit
to ddddddanni/Cirq
that referenced
this pull request
Jul 15, 2025
- Serialize CalibrationTag as a tag rather than use a custom token index field. - This tag was not converted over to the new Tag message since I didn't think anyone was still using it.
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.