Skip to content

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jun 24, 2025

  • Remove cirq-rigetti tests from ci-daily.yml
  • Remove cirq-rigetti tests from ci.yml
  • Hardcode exclusion of cirq_rigetti in cirq-core unit tests
  • Drop cirq-rigetti requirements from dev.env.txt
  • Exclude cirq-rigetti from typecheck

Partially implements #7297

Also skip installation of format requirements which may be redundant.
@github-actions github-actions bot added size: M 50< lines changed <250 size: S 10< lines changed <50 and removed size: M 50< lines changed <250 size: S 10< lines changed <50 labels Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (a0be828) to head (c6a9435).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7433      +/-   ##
==========================================
- Coverage   98.70%   98.68%   -0.02%     
==========================================
  Files        1119     1092      -27     
  Lines       98445    96546    -1899     
==========================================
- Hits        97167    95277    -1890     
+ Misses       1278     1269       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas force-pushed the disable-cirq-rigetti-tests branch from a4fc1bb to df49f7d Compare June 24, 2025 19:11
@pavoljuhas
Copy link
Collaborator Author

ci-daily and ci-weekly workflows passed at df49f7d.
OK to revert c98734d.

@pavoljuhas pavoljuhas marked this pull request as ready for review June 24, 2025 20:23
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners June 24, 2025 20:23
@pavoljuhas pavoljuhas requested review from senecameeks and mhucka June 24, 2025 20:23
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

mhucka

This comment was marked as duplicate.

@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 25, 2025
@pavoljuhas pavoljuhas removed this pull request from the merge queue due to a manual request Jun 25, 2025
@pavoljuhas
Copy link
Collaborator Author

NTS and Others: let us put this on hold until after #7436 is merged and used in docs build.

@pavoljuhas
Copy link
Collaborator Author

The update of QVM notebooks in #7428 is now online, for example, at https://quantumai.google/cirq/simulate/qvm_basic_example.

Good to proceed here.

@pavoljuhas pavoljuhas enabled auto-merge July 1, 2025 23:27
@pavoljuhas pavoljuhas added this pull request to the merge queue Jul 1, 2025
Merged via the queue into quantumlib:main with commit 45a0ead Jul 1, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the disable-cirq-rigetti-tests branch July 1, 2025 23:55
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull request Jul 15, 2025
- Remove cirq-rigetti tests from ci-daily.yml
- Remove cirq-rigetti tests from ci.yml
- Hardcode exclusion of cirq_rigetti in cirq-core unit tests
- Drop cirq-rigetti requirements from dev.env.txt
- Exclude cirq-rigetti from typecheck

Partially implements quantumlib#7297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants