Skip to content

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Jun 21, 2025

Context: Constructing circuit using Circuit.from_moment instead of passing all the moments to Circuit() can improve the construction performance of Circuit as being suggested by NoureldinYosri@.

Also did some minor improvements of imports.

@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 21, 2025
@babacry babacry closed this Jun 21, 2025
@babacry babacry reopened this Jun 21, 2025
@babacry babacry force-pushed the faster_circuit_construction branch 2 times, most recently from 7f6d8cf to c842f4c Compare June 21, 2025 03:41
@babacry babacry force-pushed the faster_circuit_construction branch from c842f4c to f40c7b9 Compare June 21, 2025 03:45
@github-actions github-actions bot added size: S 10< lines changed <50 and removed size: M 50< lines changed <250 labels Jun 21, 2025
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (4c9b173) to head (f40c7b9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7431      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97965    97966       +1     
==========================================
  Hits        96687    96687              
- Misses       1278     1279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babacry babacry self-assigned this Jun 23, 2025
@babacry babacry marked this pull request as ready for review June 23, 2025 20:45
@babacry babacry requested review from vtomole and a team as code owners June 23, 2025 20:45
@babacry babacry requested a review from senecameeks June 23, 2025 20:45
@babacry
Copy link
Collaborator Author

babacry commented Jun 23, 2025

Hey, @NoureldinYosri wonder if you can help take a look at this?

@babacry babacry requested a review from NoureldinYosri June 23, 2025 20:46
Copy link
Collaborator

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @babacry

@NoureldinYosri NoureldinYosri added this pull request to the merge queue Jun 23, 2025
Merged via the queue into quantumlib:main with commit bcd9528 Jun 23, 2025
35 checks passed
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 25, 2025
Context: Constructing circuit using Circuit.from_moment instead of
passing all the moments to Circuit() can improve the construction
performance of Circuit as being suggested by NoureldinYosri@.

Also did some minor improvements of imports.
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull request Jul 15, 2025
Context: Constructing circuit using Circuit.from_moment instead of
passing all the moments to Circuit() can improve the construction
performance of Circuit as being suggested by NoureldinYosri@.

Also did some minor improvements of imports.
@babacry babacry deleted the faster_circuit_construction branch July 16, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants