Skip to content

Conversation

suyashdamle
Copy link
Contributor

[Minor Update] First contribution. Updating documentation

@suyashdamle suyashdamle requested review from vtomole, cduck and a team as code owners August 22, 2023 21:36
@suyashdamle suyashdamle requested a review from viathor August 22, 2023 21:36
@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6e38a27) 97.60% compared to head (dd7c7b2) 97.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6255      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files        1116     1116              
  Lines       95772    95772              
==========================================
- Hits        93481    93480       -1     
- Misses       2291     2292       +1     
Files Changed Coverage Δ
cirq-core/cirq/protocols/json_serialization.py 97.68% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 23, 2023
@CirqBot
Copy link
Collaborator

CirqBot commented Aug 23, 2023

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 23, 2023
@vtomole
Copy link
Collaborator

vtomole commented Aug 23, 2023

@pavoljuhas Why is codecov/project failing? This PR doesn't touch any source code.

@pavoljuhas
Copy link
Collaborator

@pavoljuhas Why is codecov/project failing? This PR doesn't touch any source code.

Some test code may skip an if-branch depending on the RNG seed.
This seems to be happening in cirq-core/cirq/vis/heatmap_test.py and should hopefully go away after #6256.

Otherwise, codecov probably has some configuration value to ignore tiny coverage deltas, I will look into that if complaints keep on coming.

@pavoljuhas pavoljuhas merged commit 86f17eb into quantumlib:master Aug 23, 2023
@suyashdamle suyashdamle deleted the docs-contrib branch August 23, 2023 07:43
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants