Changed FakeQuantumRunStream to support arbitrary response and exception timing #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit addressed several issues:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6253 +/- ##
==========================================
- Coverage 97.88% 97.88% -0.01%
==========================================
Files 1104 1106 +2
Lines 95692 95778 +86
==========================================
+ Hits 93667 93751 +84
- Misses 2025 2027 +2
☔ View full report in Codecov by Sentry. |
maffoo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
FakeQuantumRunStreamhas the limitation that a response or exception is only fired when it receives a request. This makes it impossible to test these scenarios:This version supports both cases:
reply()to send a response or raise an exception at any moment.message_idto one from a different request.With this functionality, it would be possible to write a test for sending requests after breaking a stream, which would have revealed a bug discovered through manual testing.
@maffoo @wcourtney