Skip to content

Fix CI requirements for Changed files test #6243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2023
Merged

Fix CI requirements for Changed files test #6243

merged 4 commits into from
Aug 16, 2023

Conversation

pavoljuhas
Copy link
Collaborator

Problem: cirq-ft/cirq_ft/algos/qrom_test.py::test_notebook fails when
executed from Changed files test CI because of missing dependencies.

Solution: Install notebook-testing requirements for this CI job.

@pavoljuhas
Trigger changed files test to run unit test with notebook
e5034df 
Add temporary comment to be deleted later.
@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 15, 2023
@pavoljuhas
Copy link
Collaborator Author

Note - Changed files test fails with

=========================== short test summary info ============================
FAILED cirq-ft/cirq_ft/algos/qrom_test.py::test_notebook - jupyter_client.kernelspec.NoSuchKernel: No such kernel named python3
============ 1 failed, 26 passed, 4435 warnings in 99.31s (0:01:39) ============
Error: Process completed with exit code 1.

@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (c193c48) 97.3% compared to head (e5034df) 97.3%.
Report is 3 commits behind head on master.

❗ Current head e5034df differs from pull request most recent head 9afc686. Consider uploading reports for the commit 9afc686 to get more accurate results

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #6243   +/-   ##
======================================
  Coverage    97.3%   97.3%           
======================================
  Files        1116    1116           
  Lines       96174   96076   -98     
======================================
- Hits        93654   93564   -90     
+ Misses       2520    2512    -8
Files Changed Coverage Δ
cirq-core/cirq/circuits/circuit_operation_test.py 100.0% <ø> (+0.1%) ⬆️
...ristic_decompositions/two_qubit_gate_tabulation.py 100.0% <ø> (ø)
cirq-ft/cirq_ft/algos/qrom_test.py 100.0% <ø> (ø)
cirq-google/cirq_google/engine/engine_client.py 100.0% <ø> (ø)
cirq-google/cirq_google/engine/engine_job_test.py 100.0% <ø> (ø)
examples/bernstein_vazirani.py 97.0% <ø> (-0.2%) ⬇️
examples/deutsch.py 96.0% <ø> (-0.6%) ⬇️
examples/shor.py 100.0% <ø> (+4.8%) ⬆️
cirq-google/cirq_google/engine/engine.py 98.1% <100.0%> (-0.1%) ⬇️
...rq-google/cirq_google/engine/engine_client_test.py 100.0% <100.0%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator Author

Note the Changed files CI job passes after d17b4e4 - report

@pavoljuhas pavoljuhas marked this pull request as ready for review August 15, 2023 23:08
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners August 15, 2023 23:08
@pavoljuhas pavoljuhas enabled auto-merge (squash) August 15, 2023 23:09
@pavoljuhas pavoljuhas merged commit 64e1a7f into quantumlib:master Aug 16, 2023
@pavoljuhas pavoljuhas deleted the ci-fix-reqs-for-changed-files-test branch August 16, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavoljuhas @tanujkhattar @CirqBot