Simplify controlled gate for SumOfProducts #5873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
most optimization and inferences were implemented for the vanilla ways (as ints, lists ..etc) of defining control values, those were ported to ProductOfSums, but for SumOfProduct they didn't make sense in most cases, however in this case what you do in the constructor effectivelly transforms SumOfProducts to ProductOfSums representation, looks good to me |
tanujkhattar
approved these changes
Oct 31, 2022
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Misc check', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the
SumOfProductscontrol value when possible (if there's only a single product in it) when constructing aControlledGate. This allows theX.controlled() -> CXoptimization when using aSumOfProductscontrol value.Add a two-step test to check
X.controlled(num_qubits=2) -> CCXoptimization, and include SumOfProducts check there too.Make use of this simplification where we were hacking it in previously.
Fixes #5883