Skip to content

Fix mypy error on master #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2022
Merged

Fix mypy error on master #5865

merged 3 commits into from
Sep 7, 2022

Conversation

tanujkhattar
Copy link
Collaborator

mypy tests on master are currently failing. See https://github.com/quantumlib/Cirq/runs/8237862866?check_suite_focus=true

This PR fixes the failing test.

google/api_core/exceptions defines code: Union[None, int]. See
https://github.com/googleapis/python-api-core/blob/fe617c205918a3e4dfddeb06123e70540898032e/google/api_core/exceptions.py#L119

However, the derived classes can assign an enum to code. See
https://github.com/googleapis/python-api-core/blob/fe617c205918a3e4dfddeb06123e70540898032e/google/api_core/exceptions.py#L222

This PR assumes that code can be Union[None, int, enum.Enum] and handles the 3 cases appropriately, thus getting rid of the mypy error.

@CirqBot CirqBot added the Size: XS <10 lines changed label Sep 7, 2022
pavoljuhas
pavoljuhas reviewed Sep 7, 2022
View reviewed changes
pavoljuhas
pavoljuhas requested changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just drop the .value attribute.

pavoljuhas
pavoljuhas approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Sep 7, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 7, 2022
@tanujkhattar tanujkhattar merged commit 4349b92 into master Sep 7, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Fix mypy error on master (quantumlib#5865)
a2cdd32 
* Fix mypy error on master

* Remove .value

* Remove unused import
@pavoljuhas pavoljuhas deleted the fix_mypy_error branch January 22, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

Assignees

@pavoljuhas pavoljuhas

Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanujkhattar @CirqBot @pavoljuhas