Pin python-rapidjson in cirq-rigetti. #5666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
requested changes
Jul 6, 2022
cirq-rigetti/requirements.txt
Outdated
| @@ -9,6 +9,9 @@ pydantic~=1.8.2 | |||
| pyjwt~=1.7.1 | |||
| pyquil~=2.28.2; python_version < "3.7" | |||
| pyquil~=3.0.0; python_version >= "3.7" | |||
| # Dependencies not pinned here in pyquil pip package. | |||
| python-rapidjson==1.0 | |||
There was a problem hiding this comment.
Suggested change
| python-rapidjson==1.0 | |
| python-rapidjson<=1.6 |
This problem is due to the latest release of rapid-json. We had a similar issue in cirq-superstaq: https://github.com/SupertechLabs/cirq-superstaq/pull/289
There was a problem hiding this comment.
Ahh good catch.
|
LGTM with Victory's suggestion. python-rapidjson has an issue for this at python-rapidjson/python-rapidjson#166 Just curious - do we have a process to unpin after python-rapidjson ships a fixup release? |
We usually just create issues for unpins so we don't forget. |
CirqBot
pushed a commit
that referenced
this pull request
Jul 7, 2022
Reverts #5666 now that python-rapidjson/python-rapidjson#166 has been fixed.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Should fix CI breaks on mac. Matches rapidjson used here: https://github.com/rigetti/pyquil/blob/v3.0.0/poetry.lock
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Reverts quantumlib#5666 now that python-rapidjson/python-rapidjson#166 has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix CI breaks on mac. Matches rapidjson used here: https://github.com/rigetti/pyquil/blob/v3.0.0/poetry.lock