Skip to content

Deprecate optimize_for_sycamore and optimize_for_xmon #5531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2022
Merged

Deprecate optimize_for_sycamore and optimize_for_xmon #5531

merged 4 commits into from
Jun 15, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 15, 2022 •
edited
Loading

@verult verult requested a review from tanujkhattar June 15, 2022 22:32
@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners June 15, 2022 22:32
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 15, 2022
@verult verult requested a review from MichaelBroughton June 15, 2022 22:36
MichaelBroughton
MichaelBroughton approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after updating the examples.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 15, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 15, 2022
@CirqBot CirqBot merged commit 8fbae53 into quantumlib:master Jun 15, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 15, 2022
@tanujkhattar
Copy link
Collaborator

@verult Ideally, we need to create google-specific versions of cz and sqrt-iswap target gatesets, which correctly handle wait gates and have additional postprocess transformers like eject_z and eject_phased_paulis.

It would be good to evaluate whether the proposed fix (i.e. using cirq.optimize_for_target_gateset with cirq-core gatesets) will be end up breaking the users flow who depend upon cg.optimized_for_sycamore or not. One way to evaluate this would be to rewrite the existing tests of cg.optimized_for_sycamore using cirq.optimize_for_target_gateset as well.

@verult
Copy link
Collaborator Author

verult commented Jun 20, 2022

Sounds good. I'm focusing on SerializableDevice and SerializableGateSet deprecations for the time being (the scope is growing larger than I anticipated). Not sure if I can get to this before the release deadline, but will take a look right after deprecations are done.

@verult
Copy link
Collaborator Author

verult commented Jun 24, 2022 •
edited
Loading

@MichaelBroughton and I chatted about this and we decided to postpone the evaluation until after the 0.15 release.

If tests break, we could perhaps make a patch release to update the deprecation warning if it's not too time consuming to do.

@verult verult mentioned this pull request Jul 7, 2022
Closed
40 tasks
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@verult @rht
Deprecate optimize_for_sycamore and optimize_for_xmon (quantumlib#5531)
9cac7d9 
* Added deprecation warnings
* Updated tests to check for deprecation warnings.
@tanujkhattar @MichaelBroughton
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@verult
Deprecate optimize_for_sycamore and optimize_for_xmon (quantumlib#5531)
7c5fd9b 
* Added deprecation warnings
* Updated tests to check for deprecation warnings.
@tanujkhattar @MichaelBroughton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
size: L 250< lines changed <1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@verult @tanujkhattar @MichaelBroughton @CirqBot