Skip to content

Tweak coverage to prepare for switching to black #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2020
Merged

Tweak coverage to prepare for switching to black #3535

merged 3 commits into from
Nov 25, 2020

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Nov 25, 2020 •
edited
Loading

These changes came out of #3516 when trying to switch to using black for formatting.

  • Add qubit_order test to cover exception case
  • Remove _unitary_ method on a test class which is not covered by tests
  • Ignore coverage check for performance tests which are not run in a standard pytest run
  • Modify the coverage script to ignore if TYPE_CHECKING blocks which don't run during tests (this resulted in unrelated formatting changes on incremental_coverage.py which apparently had never been formatted by yapf)

@maffoo maffoo requested a review from a team November 25, 2020 18:32
@maffoo maffoo requested review from cduck and vtomole as code owners November 25, 2020 18:32
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 25, 2020
balopat
balopat approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 25, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 25, 2020
@CirqBot CirqBot merged commit baef78d into master Nov 25, 2020
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 25, 2020
@CirqBot CirqBot deleted the u/maffoo/pre-coverage branch November 25, 2020 19:54
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

1 more reviewer

@balopat balopat balopat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maffoo @balopat @CirqBot