-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
good part-time projectA meaty non-urgent issue with a substantial amount of work to be done.A meaty non-urgent issue with a substantial amount of work to be done.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemskind/taskA task that's part of a larger effortA task that's part of a larger effortno QC knowledge neededWant to contribute to Cirq, but don't know quantum computing? This issue is for you.Want to contribute to Cirq, but don't know quantum computing? This issue is for you.priority/after-1.6Leave for after the Cirq 1.6 releaseLeave for after the Cirq 1.6 releasetriage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on
Description
Describe the issue
The internal software pyle has some more rules activated for ruff check
analysis of the code.
We should enable them in Cirq as well to enforce similar code-quality requirements.
The extra rules are (note that some may need the preview
option):
- "B005",
- "B033",
- "C4",
- "D419",
- "F602",
- "F632",
- "F901",
- "FURB101",
- "FURB103",
- "FURB105",
- "FURB116",
- "FURB131",
- "FURB132",
- "FURB136",
- "FURB142",
- "FURB145",
- "FURB148",
- "FURB166",
- "FURB167",
- "FURB168",
- "FURB169",
- "FURB171",
- "FURB192",
- "ISC",
- "N804",
- "N805",
- "NPY201",
- "PERF101",
- "PERF102",
- "PERF402",
- "PERF403",
- "PLE0302",
- "PLE1205",
- "PLE1206",
- "PLE1310",
- "PLR0124",
- "PLR0206",
-
"PLR1701",note: remapped to SIM101 - "PLR1711",
- "PLR1730",
- "PLR1733",
- "PLR1736",
- "PLW0120",
- "PLW0245",
- "PLW0406",
- "PLW1501",
- "RET507",
- "RET508",
- "RUF005",
- "RUF013",
- "RUF015",
- "RUF019",
- "RUF027",
- "RUF200",
- "SIM103",
- "SIM110",
- "SIM113",
- "SIM115",
- "SIM116",
- "SIM210",
- "SIM211",
- "SIM222",
- "SIM223",
- "SIM401",
-
"TID251",note: we have no check for banned api imports - "UP004",
- "UP010",
- "UP018",
- "UP028",
- "UP034",
- "UP035",
Tell us the version of Cirq where this happens
1.6.0.dev0 at e7636e0
Metadata
Metadata
Assignees
Labels
good part-time projectA meaty non-urgent issue with a substantial amount of work to be done.A meaty non-urgent issue with a substantial amount of work to be done.kind/healthFor CI/testing/release process/refactoring/technical debt itemsFor CI/testing/release process/refactoring/technical debt itemskind/taskA task that's part of a larger effortA task that's part of a larger effortno QC knowledge neededWant to contribute to Cirq, but don't know quantum computing? This issue is for you.Want to contribute to Cirq, but don't know quantum computing? This issue is for you.priority/after-1.6Leave for after the Cirq 1.6 releaseLeave for after the Cirq 1.6 releasetriage/acceptedA consensus emerged that this bug report, feature request, or other action should be worked onA consensus emerged that this bug report, feature request, or other action should be worked on