-
Notifications
You must be signed in to change notification settings - Fork 467
Pybind options #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pybind options #3317
Conversation
…ons. Adds options.
66120b7
to
544bdee
Compare
After discussing with Lori, the embedded python interpreter has been removed. I'm not aware of any alternative ways to get OptKing's options from python to the c++ options object, so I've just reverted. There are a number of new options available to be set in Psi4. I haven't added docstrings because the docs are still pulled directly from optking. I've also removed any value restrictions so that additional keyword values like |
…onda. Conda release coming soon
c-f shows 0.4.2 as latest online, but Psi4 can't find it yet (nor can I find it with a local Update: conda should be able to find 0.4.2 now |
Fix Psi4 reference
Hi Alex, I made a change to your branch to collect the ooo package from conda. not sure why it wasn't there before (other than that I was building it from src for a while). |
…dds opt to allowed groups for cli tests
optking cf now explicitly sets python_min "3.9". Turn back on CMAKE_INSIST - should fix azure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my confusion over your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the new optking and for the change in plan for options processing!
Description
This PR moves optking's type and value validation for options from Psi4 to pydantic.
Allowed options are detected at compile time. Removes need to sync options. (REVERTED)
Some tests needed to be updated after changes to the IRC code.
User API & Changelog headlines
irc_traj.<pid>.xyz
file will now be written for irc jobs andopt_traj.<pid>.xyz
file can also be requested for non irc jobs.set frozen_bend (" ")
) no long works. Please useset frozen_bend ""
to erase a previously set value.Dev notes & details
of those fields to be added to the options object. (REVERTED)
python setup.py
from optking/Cmakelists.txt. Prepares for removal ofsetup.py
. I'm delaying optkings move to pyproject.toml until after this PR so there'll be a deprecation notice for the time being.Checklist
test_optking.py
)Status