Skip to content

pin hdf5=1.14.3 and job pool #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2025
Merged

pin hdf5=1.14.3 and job pool #3260

merged 3 commits into from
Jan 8, 2025

Conversation

loriab
Copy link
Member

@loriab loriab commented Jan 7, 2025 •
edited
Loading

Description

Dev notes & details

  • the conda 1.14.4 packages aren't setting HDF5_VERSION, which psi4 expects. this pins to 1.14.3 to avoid the error.
  • Ninja long has started more files compiling in libmints than it should, resulting in OOM errors. We've been constraining the threads for the whole compile, but job pools can isolate to a portion of libmints files. it'll be trial-and-error to get the cutoffs right. Leaving the azure as Makefiles b/c faster.

Checklist

Status

  • Ready for review
  • Ready for merge

@loriab loriab mentioned this pull request Jan 7, 2025
Closed
9 tasks
JonathonMisiewicz
JonathonMisiewicz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@loriab loriab added this to the Psi4 1.10 milestone Jan 7, 2025
@loriab loriab added the build label Jan 7, 2025
@jturney jturney added this pull request to the merge queue Jan 8, 2025
Merged via the queue into psi4:master with commit 9fa19f9 Jan 8, 2025
6 checks passed
@loriab loriab mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturney jturney jturney approved these changes

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
Psi4 1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@loriab @jturney @JonathonMisiewicz