Update libxc to version 7 #3231
Conversation
| @@ -20,7 +20,7 @@ else() | |||
| # Default: use a stable release tarball of libxc. To use the | |||
| # development version of libxc, instead, comment the URL line, | |||
| # and uncomment the GIT lines. | |||
| URL https://gitlab.com/libxc/libxc/-/archive/6.2.2/libxc-6.2.2.tar.gz | |||
| URL https://gitlab.com/libxc/libxc/-/archive/7.0.0/libxc-7.0.0.tar.gz | |||
There was a problem hiding this comment.
so either v6 or v7 should work at build-time?
iirc, libxc has SameMajorVersion for its cmake tolerant version range. since find_package(libxc 6.2) it'll likely reject 7, so we'll need to put in the extra logic psi-side to allow 6 or 7 like we had earlier in the year for allow 5 or 6. also, the codedeps.yaml at top level will likely need edits. these are mostly notes to myself and/or explanation if CI fails.
There was a problem hiding this comment.
Yeah the API hasn't changed, only the ABI.
|
I made a change that should have no effect except poking the CI. I want to check that it now pulls v7 from c-f and then fails the cmake detection b/c it wants v6. |
|
Ok, failed as anticipated, and now I've edited the branch to allow v6 or v7. If this build ok, gtg. |
Description
Updates CMakeLists to pull libxc 7.0.0
User API & Changelog headlines
Dev notes & details
Questions
Checklist
Status