Fix typo in SplitJK::set_lr_symmetric #3055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to @JonathonMisiewicz for catching this one!
This PR fixes a typo in
SplitJK::set_lr_symmetric, wherein thelr_symmetric_variable is assigned to itself rather than the intended behavior of being assigned to the function input.This also opens up the question of why this wasn't caught in testing, which I plan on exploring further and addressing in a second PR. Currently, composite methods where
LinKis used, throw exceptions for cases wherelr_symmetric_is set to false; but composite methods usingCOSXdoes not.User API & Changelog headlines
N/A
Dev notes & details
SplitJK::set_lr_symmetricnow behaves as intended.Questions
N/A
Checklist
Status