Skip to content

Conversation

loriab
Copy link
Member

@loriab loriab commented Nov 19, 2021

Description

In accordance with MolSSI/QCElemental#275, return certain files in qcschema to be pruned down by user protocols. Bump qcel to 0.24.0 (and qcng to 0.23.0 once it's minted). Note that this can't handle the wfn file b/c binary. And it can't handle timer.dat b/c there's no fixed place it lands (I can get it to save calling schema_wrapper directly but not for QCEngine calling psi4).

Checklist

Status

  • Ready for review
  • Ready for merge

@loriab loriab added this to the Psi4 1.5 milestone Nov 19, 2021
@loriab loriab added the schema deploys or develops MolSSI/QCSchema label Nov 20, 2021
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either approach for timer.dat. LGTM - just remember to either include the extra comment or remove the line before this gets merged in. I'm fine with either.

Copy link
Member

@andysim andysim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hokru hokru merged commit 0163e51 into psi4:master Nov 22, 2021
@loriab loriab deleted the sept21qcdb_rb2 branch November 22, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema deploys or develops MolSSI/QCSchema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants