-
Notifications
You must be signed in to change notification settings - Fork 467
Enable getting basis sets through BSE library #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Lori A. Burns <lori.burns@gmail.com>
Co-authored-by: Lori A. Burns <lori.burns@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does refscf
disagree between mints2-bse
and mints2
?
I think Ben mentioned to me that it's because of revision of the basis set, and if a |
The output file included in the PR uses |
The "base" basis changed, too, from DZ to 6-31g. Only one atom left with it, if I'm reading it right. mints2 (usual)
mints2-bse
|
Thanks. In that case, can we change the comment at the start of the file to mention that? As written, I thought the two energies were supposed to be identical. |
Sounds good. This is why I like parameterized pytest for seeing the input differences. @bennybp, did I get the why-different reasons right above? And if you're changing that comment, maybe regenerate the ref file w/o test fail: |
Well that was sloppy of me. Thanks for catching that |
I'm letting @loriab merge, since she's more familiar with MolSSI interfaces. |
Description
This PR allows for using basis sets from the Basis Set Exchange library (https://github.com/MolSSI-BSE/basis_set_exchange) directly in psi4.
To use a basis set from the BSE, you prefix the name of the basis set with
bse:
. Optionally, you can specify the version with a suffix (like:1
)Also can be used with
assign
Using these of course requires that the BSE be installed. This should be accessible from both schema/json and psithon.
User API & Changelog headlines
Dev notes & details
bse:
Questions
None
Checklist
Status