Remove superfluous PsiOutStream includes #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
approved these changes
Nov 30, 2022
2c56126 to
51c5af6
Compare
loriab
approved these changes
Nov 30, 2022
|
please rebase to fix CI |
|
Rebasing is not trivial for some reason, I am getting this error on force-push
Tried a few things to get a new token, etc. with no avail. I can work around this, but only a bit later. |
|
For this you need to give your token the "workflow" permission. Go to your token https://github.com/settings/tokens, click on it and add the "workflow" scope from the list. |
51c5af6 to
58b1a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #2686 has accidentally added some superfluous includes of
libpsi4util/PsiOutStream.h, and I also missed removing a superfluous printf line. No real harm done, but they can be removed.User API & Changelog headlines
Dev notes & details
Checklist
Status