Skip to content

Remove set-but-unused labels (char arrays) from ccdensity::RHO_Params #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2022
Merged

Remove set-but-unused labels (char arrays) from ccdensity::RHO_Params #2805

merged 2 commits into from
Nov 29, 2022

Conversation

TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Nov 27, 2022 •
edited
Loading

Description

There are some char arrays in ccdensity::RHO_Params that are set in get_rho_params but are otherwise never used. This PR removes them. This rectifies a few warnings with GCC 12, caused by the sprintf calls used to set them.

User API & Changelog headlines

  • No user-visible changes

Dev notes & details

  • R1B_lbl and similar unused members of RHO_Params are removed, except R1A_lbl which becomes not unused if EOM_DEBUG is defined.

Checklist

  • No new features
  • Tests run by the CI are passing

Status

  • Ready for review
  • Ready for merge

@TiborGY TiborGY marked this pull request as ready for review November 28, 2022 15:42
@maxscheurer maxscheurer merged commit 65baa8e into psi4:master Nov 29, 2022
@JonathonMisiewicz JonathonMisiewicz added cc For all issues involving the CC module, ground-state energies to response properties. cleanup For issues where the goal is to make Psi4 a little cleaner. labels Nov 29, 2022
@JonathonMisiewicz JonathonMisiewicz added this to the Psi4 1.7 milestone Nov 29, 2022
@TiborGY TiborGY deleted the ccden_labels branch November 30, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxscheurer maxscheurer maxscheurer approved these changes

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

Assignees
No one assigned
Labels
cc For all issues involving the CC module, ground-state energies to response properties. cleanup For issues where the goal is to make Psi4 a little cleaner.
Projects
None yet
Milestone
Psi4 1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@TiborGY @maxscheurer @JonathonMisiewicz