Remove unused approximate excitation level (AEL) code #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lothian
approved these changes
Aug 10, 2022
JonathonMisiewicz
approved these changes
Aug 10, 2022
loriab
approved these changes
Aug 10, 2022
TiborGY
added a commit
to TiborGY/psi4attic
that referenced
this pull request
Aug 10, 2022
This was referenced Aug 10, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the approximate excitation level (AEL) code. It is not called anywhere C++-side, it is not
PSI_APIand I do not think it is exported to Py-side. So dead code as far as I can tell.Plus, it might also be somehow broken as well, judging by this comment:
There is an AEL expert option for the
ccdensitymodule, however as far as I can tell setting it true would not do anything at all, as there is no code that would call the AEL function removed by this PR. Therefore this PR also removes the defunct option.Please note that this PR does not touch the AEL calculation in
cclambda/projections.cc, as it is completely unrelated.If this is merged I will submit the file to psi4attic. This is another shard of the #2642 mega-PR that can be merged independently.
Todos
Status