Skip to content

Conversation

lazaroid
Copy link
Contributor

Description

Adds contributing excitations to tdscf output for non-C1 symmetry.

Checklist

Status

  • Ready for review
  • Ready for merge

@JonathonMisiewicz
Copy link
Contributor

I'll review this once it passes tests. test_cppe.py:test_cppe_tdscf_uhf is currently failing. Based on the error message, this has nothing to do with CPPE but represents an indexing error in the code. For a first debug attempt, I would recommend removing both CPPE and the comparison against reference energies, and make sure the TDSCF completes in the first place.

Let me know if you need assistance.

@lazaroid
Copy link
Contributor Author

Gah! I didn't know about the pytest test cases (the standard tdscf-n set ran OK, somewhat surprisingly). A standard copy-paste and then missing one part that needed changing! I've corrected it.

My version of pytest is too old to run the tests (apparently) but extracting the various bits out of the pytest file and running that as a standard input file worked OK.

@JonathonMisiewicz
Copy link
Contributor

Tests are passing, excellent!

Please update output.ref for tdscf-7 and any of the other tdscf tests, so we can see how this PR changes the output printing.

@lazaroid
Copy link
Contributor Author

I think that should have done the trick. (I ran the tdscf tests and then overwrote the respective output.ref files with the generated output.dat files.) I think the only differences are numerical errors during SCF and then formatting of the output. All final results should be unchanged.

Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@JonathonMisiewicz JonathonMisiewicz added scf Involves general SCF: convergence algorithms, RHF/UHF/ROHF/CUHF... feature Extends an existing Psi feature or develops a new one. labels Jun 15, 2022
@JonathonMisiewicz JonathonMisiewicz added this to the Psi4 1.7 milestone Jun 15, 2022
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jturney jturney merged commit a04c807 into psi4:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Extends an existing Psi feature or develops a new one. scf Involves general SCF: convergence algorithms, RHF/UHF/ROHF/CUHF...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants