Skip to content

Potential bug in sad.cc: definition of pseudo-orbitals #3137

@susilehtola

Description

@susilehtola

As a result of in-person collaboration on #3136 with @loriab in Lausanne, I noticed a bug in the SAD code:

C_DSCAL(nbf, occ->get(i), &Coccp[0][i], nocc);

The pseudo-orbitals should be obtained by multiplying the orbital with the square root of their occupation to reproduce the correct density matrix C occ C^T.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions