Skip to content

Improve AST safety check #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2024
Merged

Improve AST safety check #4290

merged 1 commit into from
Mar 23, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Mar 22, 2024 •
edited
Loading

Fixes #4288, regressed by #4270

@github-actions GitHub Actions
Copy link

diff-shades reports zero changes comparing this PR (22f2570) to main (c9d2635).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra
JelleZijlstra approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel ideally we should only reformat real docstrings, but this still preserves the invariant that we only change strings that aren't executed, so this is fine.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 836acad into psf:main Mar 23, 2024
@hauntsaninja hauntsaninja deleted the ast-safety branch March 23, 2024 02:37
@hauntsaninja hauntsaninja mentioned this pull request Apr 12, 2024
Closed
@hauntsaninja hauntsaninja mentioned this pull request May 13, 2024
Closed
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When reformatting a triple-quote string, black fails with an INTERNAL ERROR: Black produced code that is not equivalent to the source
2 participants
@hauntsaninja @JelleZijlstra