Skip to content

Remove redundant 3.6 code and bump mypy's python_version to 3.7 #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

Remove redundant 3.6 code and bump mypy's python_version to 3.7 #3313

merged 1 commit into from
Oct 7, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 7, 2022

Description

The https://github.com/psf/black/releases/tag/22.10.0 removed runtime support for EOL Python 3.6. 🚀

We can remove a few old checks and config.

Updating the mypy config means we can remove a couple of # type: ignore.

Checklist - did you ...

  • [n/a?] Add an entry in CHANGES.md if necessary?
  • [n/a] Add / update tests if necessary?
  • [n/a] Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

diff-shades reports zero changes comparing this PR (acef2f1) to main (27d2014).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit b60b85b into psf:main Oct 7, 2022
@JelleZijlstra
Copy link
Collaborator

Thank you!

@hugovk hugovk deleted the rm-3.6 branch October 7, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @JelleZijlstra