Skip to content

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Sep 26, 2022

Description

I resolved the merge conflicts in #2996. This PR is that PR with a few tweaks on top.

Closes #2996, resolves #1872.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@ichard26 ichard26 added the F: empty lines Wasting vertical space efficiently. label Sep 26, 2022
@ichard26 ichard26 added this to the Release 22.9.0 milestone Sep 26, 2022
@ichard26
Copy link
Collaborator Author

I should mention that @felix-hilden and I "approved" the original PR. We didn't actually mark our reviews as approving, but we liked the style change and approved of the implementation.

@github-actions
Copy link

diff-shades results comparing this PR (af30118) to main (af3de08). The full diff is available in the logs under the "Generate HTML diff report" step.

╭───────────────────────── Summary ─────────────────────────╮
│ 15 projects & 610 files changed / 715 changes [+549/-166] │
│                                                           │
│ ... out of 2 279 946 lines, 10 403 files & 23 projects    │
╰───────────────────────────────────────────────────────────╯

Differences found.

What is this? | Workflow run | diff-shades documentation

@ichard26 ichard26 marked this pull request as draft September 26, 2022 02:05
@ichard26
Copy link
Collaborator Author

image
This shouldn't be happening, will look into it soon.

@ichard26 ichard26 removed this from the Release 22.9.0 milestone Sep 29, 2022
@ichard26 ichard26 added this to the Release 23.2.0 milestone Feb 1, 2023
@DanielNoord
Copy link
Contributor

I attempted a new rebase without the refactoring in #3932. Please consider reviewing it so that the new formatting can go into the preview mode.

@JelleZijlstra
Copy link
Collaborator

@ichard26 are you still interested in this as a pure refactor? I merged #3932 which makes the behavior change.

@hauntsaninja
Copy link
Collaborator

Since #3932 was merged and this has a bunch of conflicts, I'll close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: empty lines Wasting vertical space efficiently.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce blank line after module docstring
5 participants