-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
C: preview styleIssues with the preview and unstable style. Add the name of the responsible feature in the title.Issues with the preview and unstable style. Add the name of the responsible feature in the title.F: linebreakHow should we split up lines?How should we split up lines?T: styleWhat do we want Blackened code to look like?What do we want Blackened code to look like?
Description
Describe the style change
I'm looking at differences between 22.8.0 and 23.1a1 on our code base, most of it looks really good ❤️ as always thanks for the great work
however there is one pattern of change that doesn't seem ideal, it's possible this has been flagged already, I wasn't sure what to look for.
22.8.0
common.models.DateTimeField: (
datetime(2020, 1, 31, tzinfo=utc) + timedelta(days=i)
),
23.1a1
common.models.DateTimeField: datetime(2020, 1, 31, tzinfo=utc) + timedelta(
days=i
),
when a line needs breaking there must be some logic to decide where to break it, I guess it will find multiple candidates and rank them somehow, it looks like in this case it's started favouring the later break, whereas before it was favouring the structurally more significant one
Metadata
Metadata
Assignees
Labels
C: preview styleIssues with the preview and unstable style. Add the name of the responsible feature in the title.Issues with the preview and unstable style. Add the name of the responsible feature in the title.F: linebreakHow should we split up lines?How should we split up lines?T: styleWhat do we want Blackened code to look like?What do we want Blackened code to look like?