Skip to content

Support oneof in templates #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Support oneof in templates #436

merged 1 commit into from
Jan 22, 2021

Conversation

fhalim
Copy link

@fhalim fhalim commented Jan 12, 2021

Rebased PR #362 against current master branch.

CC @lpabon

@fhalim fhalim mentioned this pull request Jan 12, 2021
Closed
@jason-fox jason-fox mentioned this pull request Jan 13, 2021
Closed
@ping-localhost
Copy link

Any chance you have time to look at this @pseudomuto? It would help me out a lot.

pseudomuto
pseudomuto approved these changes Jan 22, 2021
View reviewed changes
Copy link
Owner

@pseudomuto pseudomuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍 Thanks for getting it rebased. I'll merge and cut a new release.

@pseudomuto pseudomuto merged commit 4ebff29 into pseudomuto:master Jan 22, 2021
@ping-localhost
Copy link

ping-localhost commented Jan 26, 2021 •
edited
Loading

Could it be that the HTML + Markdown templates still need to be adapted to properly show the oneof's in their output? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudomuto pseudomuto pseudomuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhalim @ping-localhost @pseudomuto