Fix duplicate hints #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the remote side sent duplicate hints (specifically more than 2) we'd hang for a long time waiting for things to time out. This is because we were hashing by address so we'd launch N go routines for those connections, but we'd only have a single cancel function. We now dedup by address to avoid this issue. There was also a bug in the logic waiting for all the cancellations to occur. That would leak a goroutine every time connectDirect timed out.
Don't send duplicate addresses in hints. Its possible for this to happen if you have multiple interfaces with the same IP address. This would cause receivers to hang for a long time before timing out because of a bug in the receive path of wormhole william.
Jacalz
pushed a commit
to rymdport/wormhole
that referenced
this pull request
Dec 28, 2022
Don't send duplicate addresses in hints. Its possible for this to happen if you have multiple interfaces with the same IP address. This would cause receivers to hang for a long time before timing out because of a bug in the receive path of wormhole william. Closes: psanford#89 [via git-merge-pr]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wormhole-william would hang for a long time if it got a message with 2 or more duplicate addresses in the direct tcp hints.