Skip to content

Conversation

jessestricker
Copy link
Contributor

@jessestricker jessestricker commented Jul 8, 2025

fixes #4284

As outlined in the linked issue, the inline compiler options should not be wrapped in an extra compilerOptions property.
See also the ts-docs for the tsconfig option.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fixes projen#4284

BREAKING CHANGE:
* **typescript:** The type of the `config` parameter of the `TsJestTsconfig.custom` function was corrected.
@jessestricker jessestricker marked this pull request as ready for review July 8, 2025 18:36
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (ad20d2c) to head (5413415).
Report is 551 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4285      +/-   ##
==========================================
- Coverage   96.34%   95.92%   -0.43%     
==========================================
  Files         192      203      +11     
  Lines       37696    42847    +5151     
  Branches     3524     2670     -854     
==========================================
+ Hits        36320    41101    +4781     
- Misses       1376     1746     +370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Congrats to your first contribution to projen and thank you!

@cdklabs-automation cdklabs-automation added this pull request to the merge queue Jul 9, 2025
Merged via the queue into projen:main with commit 7cec9ec Jul 9, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline ts-jest tsconfig options use wrong type
3 participants