remove stacktrace completely from errorutil #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused 'os' import - Remove unused 'errorutil' import Fixes lint errors from golangci-lint
- Replace all deprecated errorutil imports with errkit - Migrate error creation patterns: * errorutil.New().WithTag() → errkit.New() * errorutil.NewWithTag() → errkit.Newf() * errorutil.NewWithErr().Msgf() → errkit.Wrapf() * errorutil.WrapfWithNil() → errkit.Wrap() with nil check * errorutil.IsTimeout() → errors.Is(err, context.DeadlineExceeded) - Updated packages: channelutil, proxy, file, maps, reader, update, url - All tests passing, golangci-lint clean 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Mzack9999
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
the earlier implementation used DEBUG env variable to add stacktrace to every error, and it was colliding with other implementations, and in general the errorutil package is deprecated and is not meant to be used because of various design choices that were made earlier that were turned out to be not a good standard practice
now we have errkit which is improved version of this but is a breaking one and the dependency path is diferent and so are the methods and etc, the pr