fix(helm): correct values scope for servicemonitor #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rkthtrifork <rkth@trifork.com>
9e49ded to
168906f
Compare
|
Mhh i am getting to old for helm :D. Thanks for spotting this. |
oliverbaehler
approved these changes
Jul 24, 2025
Thank our end-to-end test complaining 😆 our renovate bot PRs for updating from 0.10.0 are getting blocked because helm template is failing. Will you make a patch release now or wait? Updating is not critical or anything, but would be nice |
|
@rkthtrifork by the end of the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the structure of #1537