feat(tenant): expose additional metrics #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
95056cd to
625483e
Compare
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
oliverbaehler
requested changes
Jul 7, 2025
Signed-off-by: Hristo Hristov <me@hhristov.info>
|
@oliverbaehler I did refactor the approach. LMK WYT |
oliverbaehler
requested changes
Jul 23, 2025
controllers/tenant/metrics.go
Outdated
Comment on lines
11
to
15
| r.Metrics.DeleteTenantStatusMetrics(tenant.GetName()) | ||
| // Expose namespace-tenant relationship | ||
| for _, ns := range tenant.Status.Namespaces { | ||
| r.Metrics.TenantNamespaceRelationshipGauge.WithLabelValues(tenant.GetName(), ns).Set(1) | ||
| } |
There was a problem hiding this comment.
Can you think of a smoother implementation than always deleting all of the exemplers? Even if so, DeletePartialMatch is very resource intensive. We should avoid doing that on every loop for scalability. However you might be able to preserve the status namespaces before reconciling and diffing between the namespaces and remove those, which are no longer in the status
controllers/tenant/manager.go
Outdated
Comment on lines
94
to
96
| // Ensuring Status metrics are exposed | ||
| r.Log.Info("Ensuring all status metrics are exposed") | ||
| r.syncStatusMetrics(instance) |
There was a problem hiding this comment.
Why is this before the loop? This wont be an accurate representation?
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
oliverbaehler
requested changes
Jul 25, 2025
oliverbaehler
requested changes
Jul 31, 2025
Signed-off-by: Hristo Hristov <me@hhristov.info>
# Conflicts: # controllers/tenant/manager.go
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
oliverbaehler
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1516