build(go.mod): reformat require blocks #2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2582 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 169 169
Lines 22463 22463
=======================================
Hits 20830 20830
Misses 1016 1016
Partials 617 617 ☔ View full report in Codecov by Sentry. |
|
The stress tests jobs seems very unstable |
andaaron
approved these changes
Jul 31, 2024
Maybe the new minio version is slower and because of that some of the wait times in the tests no longer work. There's 1 failed request here or there more often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
Which issue does this PR fix:
Nothing
What does this PR do / Why do we need it:
As part of #2532 I reformat the go.mod file. This introduce more complex merge conflict, if the go.mod was updated on main.
Note: #2580 removes large part of the THIRD-PARTY-LICENSES.md file, which I re-introduced here.
This PR does not update any dependencies. Only the require blocks has been merged. At the end, no changes are introduces at the go.sum file, even after running go mod tidy. This guarantees that the same versions has been not changes.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.