Skip to content

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jul 8, 2024

Notes

@rchincha
Copy link
Contributor

rchincha commented Jul 9, 2024

Thanks @jkroepke
Doing a test CI run so we understand scope of changes required.

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 9, 2024

Thanks @jkroepke Doing a test CI run so we understand scope of changes required.

I know, currently everything is broke and I have also compile error locally. Thats why the PR is in draft and not ready to review. However, I would like to share the info that someone is working on it.

@jkroepke
Copy link
Contributor Author

The only exception here is

https://github.com/project-zot/zot/actions/runs/9847797795/job/27233306056?pr=2532

11% binary increase size. Thats nothing, what I can do here.

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 11, 2024

Doing a test CI run so we understand scope of changes required.

could you please do it again?

And I have no access to the license jobs.

What is the error? And what is the solution?

@rchincha
Copy link
Contributor

@jkroepke One more rebase pls.
The license issue is likely resolved.

@jkroepke jkroepke marked this pull request as ready for review July 17, 2024 06:24
@jkroepke
Copy link
Contributor Author

@rchincha done

@jkroepke jkroepke changed the title bump all dependencies build(deps): bump all dependencies Jul 18, 2024
@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 18, 2024

@rchincha Could you please trigger the CI again?

No idea about snyk

@jkroepke
Copy link
Contributor Author

I need assistance here.

Check binary size. I can do nothing here.

It checks for warnings, but there is an warning which can be considered as expected:

{"level":"warn","config version":"1.1.0","supported version":"1.1.0+dev","goroutine":1,"caller":"zotregistry.dev/zot/pkg/cli/server/root.go:745","time":"2024-07-18T16:48:06.654323+02:00","message":"config dist-spec version differs from version actually used"}

@jkroepke
Copy link
Contributor Author

The distribution project now using a way more modern S3 library from AWS which has some incompatibilities with minio.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (7729fef) to head (a2426db).

Files Patch % Lines
pkg/storage/imagestore/imagestore.go 50.00% 0 Missing and 2 partials ⚠️
pkg/storage/local/driver.go 75.00% 1 Missing ⚠️
pkg/storage/s3/driver.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         169      169           
  Lines       22463    22471    +8     
=======================================
+ Hits        20828    20836    +8     
  Misses       1018     1018           
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 22, 2024

@rchincha I created 2 additional PR #2555 and #2556 which are dependencies for this PR.

In general, CI is looking fine, with both PRs are merged.

  • Verify Example Config: No idea whats going one there.
  • snyk is always red
  • binary size: Reports an 11% bigger binary.

Otherwise, you can do an intermediate review, if you agree with the code changes.

@jkroepke jkroepke requested a review from rchincha July 22, 2024 06:07
@jkroepke
Copy link
Contributor Author

this feels ready to review

@rchincha
Copy link
Contributor

@jkroepke can you rebase pls?

@jkroepke
Copy link
Contributor Author

@jkroepke can you rebase pls?

To lax merge conflict, I cut the reformat of the go.mod into a dedicated PR: #2582

@andaaron
Copy link
Contributor

andaaron commented Jul 31, 2024

I merged the other PR. Opening a separate PR was a very good idea. I was about to suggest it.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@andaaron
Copy link
Contributor

andaaron commented Aug 2, 2024

@jkroepke the go code changes look ok, but there are CI failures.

The failure in Check binary size increase I think we can live with.
The Verify Example Config job is failing because the version in the example config files doesn't match the version in the imported library.
The License Compliance failures I reviewed and identified false positives which I marked as such in FOSSA.
The snyk results I need to review at some point
The GC tests I restarted (we need to find a way to stabilize those).
@jkroepke please look at the failures in the Running tests jobs.

jkroepke and others added 2 commits August 2, 2024 13:18
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
Copy link
Contributor Author

jkroepke commented Aug 2, 2024

everything is green now.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@rchincha
Copy link
Contributor

rchincha commented Aug 2, 2024

PR binary size: 39018817 Bytes
main branch binary size: 34980161 Bytes
zot minimal binary increased by 11.54% comparing with main

@rchincha rchincha merged commit fa4b699 into project-zot:main Aug 2, 2024
36 of 40 checks passed
@jkroepke jkroepke deleted the deps branch August 3, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants