-
Notifications
You must be signed in to change notification settings - Fork 147
build(deps): bump all dependencies #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @jkroepke |
I know, currently everything is broke and I have also compile error locally. Thats why the PR is in draft and not ready to review. However, I would like to share the info that someone is working on it. |
The only exception here is https://github.com/project-zot/zot/actions/runs/9847797795/job/27233306056?pr=2532 11% binary increase size. Thats nothing, what I can do here. |
could you please do it again? And I have no access to the license jobs. What is the error? And what is the solution? |
@jkroepke One more rebase pls. |
@rchincha done |
@rchincha Could you please trigger the CI again? No idea about snyk |
I need assistance here. Check binary size. I can do nothing here. It checks for warnings, but there is an warning which can be considered as expected:
|
The distribution project now using a way more modern S3 library from AWS which has some incompatibilities with minio. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 169 169
Lines 22463 22471 +8
=======================================
+ Hits 20828 20836 +8
Misses 1018 1018
Partials 617 617 ☔ View full report in Codecov by Sentry. |
@rchincha I created 2 additional PR #2555 and #2556 which are dependencies for this PR. In general, CI is looking fine, with both PRs are merged.
Otherwise, you can do an intermediate review, if you agree with the code changes. |
this feels ready to review |
@jkroepke can you rebase pls? |
I merged the other PR. Opening a separate PR was a very good idea. I was about to suggest it. |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke the go code changes look ok, but there are CI failures. The failure in |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
everything is green now. |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
PR binary size: 39018817 Bytes |
Notes
forcepathstyle=true
(Allow setting s3 forcepathstyle without regionendpoint distribution/distribution#4291)