feat: add ability to override platform OS #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 60.41% 60.51% +0.10%
==========================================
Files 59 59
Lines 6444 6461 +17
==========================================
+ Hits 3893 3910 +17
Misses 1906 1906
Partials 645 645 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This LGTM, while you're doing this, since it's basically the same change, do you want to add |
5b782dc to
8f01b75
Compare
|
Still debating if this should actually be a image tag directive like |
|
https://github.com/project-zot/zot/blob/main/build/stacker.yaml#L61 ^ hmm..maybe this PR can be shortened. |
Currently, stacker is bound to the host platform for all its operations. This PR allows for build a container image different from the host platform by overriding the platform OS. Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
Local test passes |
hallyn
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stacker is bound to the host platform for all its operations. This PR allows for build a container image different from the host platform by overriding the platform OS.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.