Skip to content

Conversation

rchincha
Copy link
Contributor

Don't follow symlinks for checksum computation - they can be broken.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.15%. Comparing base (da5e3c8) to head (bb7be51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          64       64           
  Lines        7525     7525           
=======================================
  Hits         4301     4301           
  Misses       2481     2481           
  Partials      743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Don't follow symlinks for checksum computation, they can be broken.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha merged commit e627e90 into project-stacker:main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant