fix: build.yaml run section needs set -e, and add -x #482
Conversation
|
1de40af to
d3ed042
Compare
|
Heh, age-old question: if my testsuite is broken so it doesn't catch failures, and you fix that, are you responsible for fixing the newly caught errors? :) Thanks, Scott. |
|
2023-08-21T15:07:26.7148382Z not ok 37 can read previous version's cache in 6sec ^ see only this failure, which is expected |
|
The base branch requires all commits to be signed. Learn more about signing commits. ^? |
Its been a long time that this has been broken. The run sections in build.yaml were executing shell scripts without '-e' and thus they would not exit on failure. The end result was that if something went amuck you had to parse through long error logs for what that was. Also * Add '-x' to sh to make it more obvious where things failed. * Add the po4a package, which is used as part of the xz build. Signed-off-by: Scott Moser <smoser@brickies.net>
d3ed042 to
d3e18af
Compare
✔️ and rebased after landing #485, so this should actually run. |
Its been a long time that this has been broken. The run sections in build.yaml were executing shell scripts without '-e' and thus they would not exit on failure.
The end result was that if something went amuck you had to parse through long error logs for what that was.
Also add '-x' here to make it more obvious where things failed.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.