Fix link failure by adding zstd-static to the alpine build container. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top commit (54b6501b188041019c19dd6d93c66838bae6c165) on alpine
zstd tree commit says:
main/zstd: split -static
That broke our build as the new zstd-dev does not contain a libzstd.a.
Thankfully the fix is as easy as adding zstd-static to the list of
alpine packages in the container.
Signed-off-by: Scott Moser <smoser@brickies.net>
ec8fc1e to
e15abfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top commit (54b6501b188041019c19dd6d93c66838bae6c165) on alpine zstd tree commit says:
That broke our build as the new zstd-dev does not contain a libzstd.a.
Thankfully the fix is as easy as adding zstd-static to the list of alpine packages in the container.