Skip to content

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Mar 9, 2023

stacker functionality depends on kernel versions and filesystem support. So useful to report this often, at least to debug issues.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha marked this pull request as ready for review March 10, 2023 18:33
@rchincha rchincha requested a review from hallyn as a code owner March 10, 2023 18:33
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #441 (f076c62) into main (7c5e09c) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head f076c62 differs from pull request most recent head 6d22b2a. Consider uploading reports for the commit 6d22b2a to get more accurate results

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   12.08%   11.87%   -0.22%     
==========================================
  Files          44       45       +1     
  Lines        5452     5551      +99     
==========================================
  Hits          659      659              
- Misses       4676     4775      +99     
  Partials      117      117              
Impacted Files Coverage Δ
pkg/stacker/check.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rchincha rchincha force-pushed the debug branch 2 times, most recently from 7cf6bbe to f076c62 Compare March 10, 2023 20:21
stacker functionality depends on kernel versions and filesystem support.
So useful to report this often, at least to debug issues.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha merged commit 8e267fc into project-stacker:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants