Skip to content

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Mar 7, 2023

Currently, the github workflows dependencies are chained as follows:

build.yaml -> ci.yaml
release.yaml -> ci.yaml
convert.yaml -> ci.yaml

build.yaml and release.yaml are inline builds but operate on different build triggers. convert.yaml is timer-based and works offline.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested review from smoser and hallyn as code owners March 7, 2023 22:22
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #438 (79da08d) into main (d805401) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   12.08%   12.08%           
=======================================
  Files          44       44           
  Lines        5451     5451           
=======================================
  Hits          659      659           
  Misses       4675     4675           
  Partials      117      117           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Currently, the github workflows dependencies are chained as follows:

build.yaml -> ci.yaml
release.yaml -> ci.yaml
convert.yaml -> ci.yaml

build.yaml and release.yaml are inline builds but operate on different
build triggers. convert.yaml is timer-based and works offline.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
it feels like there should be a simpler way to do this. i'm surprised the checkouts don't get tags (so 'git describe' would work).
but i'm fine with this and happy to have it work.

@rchincha rchincha merged commit 07b9cb7 into project-stacker:main Mar 10, 2023
@rchincha rchincha linked an issue Mar 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: version shows hash and no version for 1.0.0-rc3
2 participants