Skip to content

Conversation

rchincha
Copy link
Contributor

Signed-off-by: Ramkumar Chinchani rchincha@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha
Copy link
Contributor Author

#347
^ this is giving trouble in the unpriv case as well as some interference from container builds likely. Meanwhile, we should also start adding regular UTs.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9c11803). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage        ?   10.77%           
=======================================
  Files           ?       44           
  Lines           ?     5421           
  Branches        ?        0           
=======================================
  Hits            ?      584           
  Misses          ?     4747           
  Partials        ?       90           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rchincha rchincha merged commit c54968a into project-stacker:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants