feat(convert): improve conversion handling #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2afaa7c to
e8ae853
Compare
79b2a86 to
debb3ec
Compare
984703a to
505df36
Compare
|
I'm sorry, but could you please add a bit of explanation to patch "[PATCH 2/5] feat: support file-to-file import copy" ? |
import /dir1/file1 -> /dir2/file2 means that we need to setup a overlaydir dest=dir2 but we also need to copy file1 as file2 there first. |
hallyn
approved these changes
Jan 31, 2023
added 5 commits
January 31, 2023 18:58
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
import /dir1/file1 -> /dir2/file2 means that we need to setup a overlaydir dest=dir2 but we also need to copy file1 as file2 there first. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
overlayfs and xattrs handling is broken wrt upstream umoci. Use a patched project-stacker/umoci@stacker instead. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.