feat: add buildkit frontend #1221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13e7020 to
10b3558
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
- Coverage 43.03% 38.75% -4.29%
==========================================
Files 35 38 +3
Lines 4143 4601 +458
==========================================
Hits 1783 1783
- Misses 2228 2686 +458
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9012851 to
31a5b00
Compare
1 task
e131442 to
e2a2d74
Compare
|
@robert-cronin just approved the refactoring changes! could we rebase this on top of that? also I think the unit test is missing the vuln report |
.dockerignore
Outdated
| @@ -0,0 +1,36 @@ | |||
| # Ignore large directories that aren't needed for building | |||
There was a problem hiding this comment.
do we need to keep this file?
There was a problem hiding this comment.
I think we could probably remove it since we just publish a single binary in the frontend image, nothing unnecessary is copied over anyway.
|
@robert-cronin maybe we can also add this under features in the documentation? |
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
0b3659d to
882cc9e
Compare
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Closes #1211
Closes #604
This PR is dependent on #1228
Example command that works using
buildctl:and for docker build (just need a very basic Dockerfile in cwd,
FROM scratchwill suffice):