Skip to content

Conversation

ArthurSens
Copy link
Member

Bumping client_golang and common requires some extra work that I just happen to be familiar with :)

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[EDIT: resolved] Why are we deferring to an otherwise-unused field in an upstream library?

@ArthurSens ArthurSens force-pushed the update-clientgolang branch from 515ab9e to 07355c9 Compare March 6, 2024 13:30
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham
Copy link
Member

bboreham commented Mar 6, 2024

Needs newer prometheus/common

Commit 4199f18c3e92.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham bboreham changed the title Bump client_golang to 1.19 Bump client_golang to 1.19, common to 0.49.1 Mar 6, 2024
@bboreham bboreham merged commit 6fd7c0c into prometheus:main Mar 6, 2024
@ArthurSens ArthurSens deleted the update-clientgolang branch March 6, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants