wip: wip allow PromQL engine to operate on immutable histogram pointers #13679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beorn7
reviewed
Mar 14, 2024
| @@ -385,7 +387,7 @@ func (it *SampleRingIterator) AtFloatHistogram(fh *histogram.FloatHistogram) (in | |||
| it.fh.CopyTo(fh) | |||
| return it.t, fh | |||
| } | |||
| return it.t, it.fh.Copy() | |||
| return it.t, it.fh | |||
There was a problem hiding this comment.
Shouldn't this also be guarded behind reuseHistograms?
|
Hello from the bug scrub! 👋🏽 @krajorama any progress on it or should we close for now? |
|
I'd like to work on this, please keep open. This is on my backlog for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13659 .
Optimize the engine in case the iterator loading histogram samples has already allocated the samples and doesn't modify them afterwards , thus there is no need to make copies. E.g. storageSeriesIterator