Skip to content

storage/remote: speed up StoreSeries by re-using labels.Builder #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2024
Merged

storage/remote: speed up StoreSeries by re-using labels.Builder #13491

merged 2 commits into from
Feb 6, 2024

Conversation

bboreham
Copy link
Member

Relabeling can take a pre-populated Builder instead of making a new
one every time. This is much more efficient.

Added a benchmark to demonstrate:

goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/storage/remote
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
                                     │  before.txt  │              after.txt              │
                                     │    sec/op    │    sec/op     vs base               │
StoreSeries/plain-4                    1.569m ±  8%   1.270m ±  5%  -19.06% (p=0.002 n=6)
StoreSeries/externalLabels-4           3.288m ±  2%   2.497m ±  8%  -24.07% (p=0.002 n=6)
StoreSeries/relabel-4                  3.252m ± 17%   3.107m ± 10%        ~ (p=0.065 n=6)
StoreSeries/externalLabels+relabel-4   5.122m ±  3%   3.414m ±  6%  -33.34% (p=0.002 n=6)
geomean                                3.045m         2.408m        -20.90%

                                     │  before.txt  │              after.txt              │
                                     │     B/op     │     B/op      vs base               │
StoreSeries/plain-4                    598.8Ki ± 0%   364.7Ki ± 0%  -39.10% (p=0.002 n=6)
StoreSeries/externalLabels-4           1.867Mi ± 0%   1.089Mi ± 0%  -41.68% (p=0.002 n=6)
StoreSeries/relabel-4                  1.348Mi ± 0%   1.119Mi ± 0%  -16.96% (p=0.002 n=6)
StoreSeries/externalLabels+relabel-4   2.630Mi ± 0%   1.119Mi ± 0%  -57.44% (p=0.002 n=6)
geomean                                1.403Mi        854.9Ki       -40.48%

                                     │ before.txt  │             after.txt              │
                                     │  allocs/op  │  allocs/op   vs base               │
StoreSeries/plain-4                    3.659k ± 0%   1.662k ± 0%  -54.58% (p=0.002 n=6)
StoreSeries/externalLabels-4           5.660k ± 0%   2.662k ± 0%  -52.97% (p=0.002 n=6)
StoreSeries/relabel-4                  7.661k ± 0%   5.663k ± 0%  -26.07% (p=0.002 n=6)
StoreSeries/externalLabels+relabel-4   9.664k ± 0%   5.663k ± 0%  -41.40% (p=0.002 n=6)
geomean                                6.257k        3.451k       -44.84%

Also simplify processExternalLabels taking advantage of Builder.Get added recently.

Switching processExternalLabels from ScratchBuilder to Builder makes the code slower for the no-build-tags implementation of labels.Labels, which I can fix, but I figured I would wait to see if anyone is affected by this. Prometheus and Grafana Agent are both using -tags stringlabels.

@bboreham
storage/remote: add BenchmarkStoreSeries
d9483bb 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
storage/remote: speed up StoreSeries by re-using labels.Builder
dcd024a 
Relabeling can take a pre-populated `Builder` instead of making a new
one every time. This is much more efficient.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This was referenced Jan 29, 2024
Merged
Merged
cstyan
cstyan approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially if we're already compiling with the build tag ourselves. The change here shouldn't be blocked on potentially 3rd party impact.

@bboreham bboreham merged commit 8655fe5 into prometheus:main Feb 6, 2024
@bboreham bboreham deleted the faster-store-series branch February 6, 2024 16:16
@machine424 machine424 mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstyan cstyan cstyan approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

Assignees
No one assigned
Labels
kind/optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @cstyan