[2.48] Backport: Native histograms vs labels (#13005) #13202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document le and quantile label transition due to native histograms Fixes: prometheus#12984 For full explanation see the related issue. The le and quantile labels are formatted as float with trailing .0 for whole number values when native histograms is enabled, e.g. 10.0. This changes the resulting series in Prometheus if previously we scraped the whole number itself, e.g. 10 over the text format. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Used to have a different signature. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
|
To clarify: This has been cherry-picked from #13005 . It would be good to have this documentation update in the current release as the lack of it is causing confusion. It's likely not enough to justify a bugfix release on its own, but let's merge it into the release branch so the next bugfix release that happens will have it. |
beorn7
approved these changes
Nov 28, 2023
|
@LeviHarrison for final call. |
LeviHarrison
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Perfectly fine by me if you want to leave this is the release branch. However, I just realized that the final release changes still haven't been merged from the release branch to main yet, so once #13227 goes through then you're good to merge here.
|
Alright #13227 is merged so this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick e399395 #13005
Fixes: #12984
For full explanation see the related issue. The le and quantile labels are formatted as float with trailing .0 for whole number values when native histograms is enabled, e.g. 10.0. This changes the resulting series in Prometheus if previously we scraped the whole number itself, e.g. 10 over the text format.