Add feature flag for PromQL experimental functions. #13103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e68b01 to
5a138b5
Compare
bboreham
approved these changes
Nov 14, 2023
promql/parser/generated_parser.y
Outdated
| @@ -22,7 +22,8 @@ import ( | |||
| "github.com/prometheus/prometheus/model/labels" | |||
| "github.com/prometheus/prometheus/model/value" | |||
| "github.com/prometheus/prometheus/model/histogram" | |||
| "github.com/prometheus/prometheus/promql/parser/posrange" | |||
|
|
|||
There was a problem hiding this comment.
This blank line causes a number of extra diffs in the generated code; is it helpful?
|
👍 besides @bboreham's comment. |
This PR adds an Experimental flag to the functions. This can be used by prometheus#13059 but also xrate and other future functions. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
5a138b5 to
c92fbf3
Compare
bboreham
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Experimental flag to the functions.
This can be used by #13059 but also xrate and other future functions.