Skip to content

Conversation

pipiland2612
Copy link
Contributor

What issue is this pull request solves?

Changes made:

  • Remove writing Label Index and Label Offset Table in the tsdb/index/index.go
  • Remove corresponding unit test

Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

Hi @bwplotka, can you review this? Thank you !

@bwplotka
Copy link
Member

bwplotka commented Aug 2, 2025

@codesome could you take a look as well?

Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as clean as a PR can get. Thanks!

@codesome codesome merged commit 64808d4 into prometheus:main Aug 5, 2025
27 checks passed
@pipiland2612 pipiland2612 deleted the Remove_label_index branch August 6, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop writing Label Index and Label Offset Table in the index
3 participants